Add conditional calling of this.cacheable() to prevent breaking #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
March 15, 2017 12:47
Add the babel/object-curly-spacing required by eslint
|
@andela-idurotola Please keep this PR focused on the actual fix. Is there a reason the configs are updated here? |
|
What are the conditions under which this was failing? |
|
After I put in the fix, only circle Ci failed and this happened because the
eslint resolved to a version of that broke peer dependencies -
[link here](https://circleci.com/gh/metalabdesign/css-js-loader/5?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link)
The best solution would be to merge in the initial upgrade to eslint before
putting this fix in.
…On Thu, Mar 16, 2017 at 5:46 PM, Neal Granger ***@***.***> wrote:
What are the conditions under which this was failing?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AIMdZbAmudEebleklmvpB4YdgtoKAkv3ks5rmWdkgaJpZM4Md2QD>
.
|
|
I agree on waiting for the separate eslint update. I'm still curious what causes the |
|
I just tried to reproduce the error now, I am unable to. Most likely a few versions have changed. While running test now with jest, I got the error |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix
TypeError: this.cacheable is not a functionby adding a conditional trigger.Found an example on css-loader here. This is called with
this.cacheable && this.cacheable();to prevent a break.